Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39851 )
Change subject: nb/intel/sandybridge: Refactor get_mem_min_tck
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39851/7/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_native.c:
https://review.coreboot.org/c/coreboot/+/39851/7/src/northbridge/intel/sandy...
PS7, Line 194: max_mem_clock_mhz
Maybe outside the scope of this patch but why are values higher than 1066MHz not possible via device […]
That was probably because getting things stable at such high frequencies is quite troublesome. We only recently got 2400 MHz to work fine.
Also, this isn't really doing what it says... It forces a certain frequency, ignoring all the fuses. So, not really "max" memory frequency, but rather "mem_clock_mhz"... This can be taken care of in a subsequent patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c49c943c87218d4d40d3168bd8b7b900b0ec2e9
Gerrit-Change-Number: 39851
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment