EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/memory.c:
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli...
PS3, Line 20: /* Use spd_index array to save mem_id */
Use spd_index matrix to correspond mem_id. And we can save the dummy spd index to reduce the size of SPD.bin.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b
Gerrit-Change-Number: 35346
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Sep 2019 13:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment