Attention is currently required from: Felix Singer, Subrata Banik, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56217 )
Change subject: mb/intel/coffeelake_rvp: Rework Kconfig
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56217/comment/6a586788_5a75b489
PS3, Line 17: Built each variant with `BUILD_TIMELESS=1` and all generated
Right, I did not include the .config file.
Would be great if you could mention this.
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56217/comment/af6733bb_57657de7
PS3, Line 15: BOARD_INTEL_COFFEELAKE_RVP8_OPTIONS
The linter complains about this: […]
What exactly did you try? Did you remove the type declarations from this file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b3d3cff5ea7a3f4d1c4ddd911240763e4891e06
Gerrit-Change-Number: 56217
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 14 Jul 2021 13:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
