Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md:
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... PS4, Line 64: Requirement from EC There are a number of changes ongoing with Chrome EC currently to support EFSv2. I think this design needs to be re-evaluated in the light of that feature.
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... PS4, Line 84: We can display charging screen after graphics PEIM execution has finished after fsp-s. If we are waiting until FSP-S i.e. ramstage to do this, can we not wait until depthcharge?