[coreboot-gerrit] Change in coreboot[master]: util/inteltool: gpio add code for dumping GPIO Community cfg registers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39511 )

Change subject: util/inteltool: gpio add code for dumping GPIO Community cfg registers
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/g... 
File util/inteltool/gpio_names/gpio_groups.h:

https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/g... 
PS7, Line 15: size
> I kept the convention naming it _size like I did in all other subsystems

IMO, we should stick to conventions of the closest code and (if possible)
not break with it in one .c file. Also, `size` often refers to the size
in bytes.

https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h 
File util/inteltool/inteltool.h:

https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h@... 
PS7, Line 385: uint16_t
> not 100% sure but I'm not aware of platforms having 32bit cfg register addresses for gpio

So why risk it? (nothing to lose btw., the struct will be padded anyway)