25 Jan
2019
25 Jan
'19
1:59 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31049 )
Change subject: src: Don't use a #defines like Kconfig symbols ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31049/4/src/superio/smsc/lpc47n207/early_ser... File src/superio/smsc/lpc47n207/early_serial.c:
https://review.coreboot.org/#/c/31049/4/src/superio/smsc/lpc47n207/early_ser... PS4, Line 61: if (reg_value != CONF_ENABLE) { braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/31049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia31aed366bf768ab167ed5f8595bee8234aac46b
Gerrit-Change-Number: 31049
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Jan 2019 04:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment