Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31832 )
Change subject: mb/gigabyte/ga-h61ma-d3v: Add new mainboard as variant
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31832/4/src/mainboard/gigabyte/ga-h61m-s2pv/...
File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb:
https://review.coreboot.org/#/c/31832/4/src/mainboard/gigabyte/ga-h61m-s2pv/...
PS4, Line 78: device pnp 2e.7 off # GPIO
Is the 'off' here correct?
https://review.coreboot.org/#/c/31832/4/src/mainboard/gigabyte/ga-h61m-s2pv/...
PS4, Line 88: io 0xf6 = 0x1c
Not sure... I think we used whacky 'irq' syntax for these generic registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37928de158bb8fbb47fbda5d1ccd4efba7edab26
Gerrit-Change-Number: 31832
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 27 Mar 2019 10:59:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment