14 Jan
2019
14 Jan
'19
11:22 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30545 )
Change subject: mb/google/hatch: Enable SD card support for hatch ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/#/c/30545/18/src/mainboard/google/hatch/variants... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30545/18/src/mainboard/google/hatch/variants... PS18, Line 103: UP_20K Why is external pull-up required?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ccaa28323b1e1fcc192e245347a96309227660b
Gerrit-Change-Number: 30545
Gerrit-PatchSet: 18
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki naresh.solanki@intel.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 14 Jan 2019 10:22:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment