Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Default to undefined fw_config value ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig@406 PS2, Line 406: When probing devices with fw_config, when the value is undefined or : unable to be located, all devices will be successfully probed, and : fw_config_probe will always return true.
Do we really need a Kconfig for this? I think it should be the default behavior i.e. […]
It is going to result in weird undefined state for things like audio where we can't have both I2S and soundwire enabled at the same time. In volteer there are also some DB combinations that would result in pins being driven when they should not be if everything was assumed to be present.
Different boards may need to make different decisions about how to handle the unprovisioned case, but probably only to some fields so it may not need a kconfig but rather careful use of the different functions in the code.