Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/common/block... PS17, Line 101: CONFIG_IA32_L3_MASK_1_DEFAULT
If you decide to drop the programming from exit car, I would recommend adding a comment here indicat […]
It has I guess always seemed to work without reprogramming the L3_MASK anyways and logically what you say makes sense, it just worries me a little when somebody went to the trouble to call out a step (maybe it was just CYA, who knows) and we don't follow it.
I guess if we run through a bunch of reboot tests w/o the extra mask programming in teardown and don't have any issues, it's probably okay.