Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30559 )
Change subject: drivers/spi: Add controller protection type ......................................................................
Patch Set 8: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/30559/8/src/drivers/mrc_cache/mrc_cache.c File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/#/c/30559/8/src/drivers/mrc_cache/mrc_cache.c@46... PS8, Line 467: return spi_flash_ctrlr_protect_region(flash, r, WRITE_PROTECT); replace tab by space
https://review.coreboot.org/#/c/30559/8/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/30559/8/src/drivers/spi/spi_flash.c@576 PS8, Line 576: const struct region *region, align with (
https://review.coreboot.org/#/c/30559/8/src/include/spi_flash.h File src/include/spi_flash.h:
https://review.coreboot.org/#/c/30559/8/src/include/spi_flash.h@210 PS8, Line 210: const struct region *region, align with (
https://review.coreboot.org/#/c/30559/8/src/soc/intel/common/block/fast_spi/... File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/#/c/30559/8/src/soc/intel/common/block/fast_spi/... PS8, Line 371: enum ctrlr_prot_type type) align with (