[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Implement the dramc init setting

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )

Change subject: mediatek/mt8183: Implement the dramc init setting
......................................................................

Patch Set 20:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
File src/soc/mediatek/mt8183/dramc_init_setting.c:

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
PS17, Line 78: ca_dll_mode[CHANNEL_A] = DLL_MASTER;
             : 	ca_dll_mode[CHANNEL_B] = DLL_SLAVE;
             : 	if (freq_group == LP4X_DDR1600)
             : 		ca_dll_mode[CHANNEL_A] = ca_dll_mode[CHANNEL_B] = DLL_SLAVE;
             :
> ca_dll_mode[CHANNEL_A] = (freq_group == LP4X_DDR1660) ? DLL_SLAVE : DLL_MASTER; […]

Done

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
PS17, Line 313: 	u16 rx_vref = 0xb;
              : 
              : 	if (operate_fsp == FSP_1)
              : 		rx_vref = 0xb;
              : 	else
              : 		rx_vref = 0x16;
> u16 rx_vref = 0x16; […]

Done

https://review.coreboot.org/c/coreboot/+/34988/17/src/soc/mediatek/mt8183/dr... 
PS17, Line 637: }
> Please add a default: here to die or assert.

Done