build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33184 )
Change subject: DO NOT SUBMIT: It is just init current BOE TV101WUM-NL2 panel, it is not final soultion of Bitland kukui project. ......................................................................
Patch Set 1:
(27 comments)
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/display.c File src/mainboard/google/kukui/display.c:
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/display.c... PS1, Line 98: return ERR; return of an errno should typically be negative (ie: return -ERR)
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/mainboard... PS1, Line 77: if (intf != NULL) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... File src/mainboard/google/kukui/panel_bitland.c:
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 31: .panel_bits_per_color = 8, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 31: .panel_bits_per_color = 8, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 32: .panel_bits_per_pixel = 24, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 32: .panel_bits_per_pixel = 24, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 33: .mode = { code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 33: .mode = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 34: .name = "1200x1920@60Hz", code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 34: .name = "1200x1920@60Hz", please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 35: .pixel_clock = 159391, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 35: .pixel_clock = 159391, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 36: .lvds_dual_channel = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 36: .lvds_dual_channel = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 37: .refresh = 60, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 37: .refresh = 60, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 38: .ha = 1200, .hbl = 141, .hso = 80, .hspw = 1, .hborder = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 38: .ha = 1200, .hbl = 141, .hso = 80, .hspw = 1, .hborder = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 39: .va = 1920, .vbl = 61, .vso = 35, .vspw = 1, .vborder = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 39: .va = 1920, .vbl = 61, .vso = 35, .vspw = 1, .vborder = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 40: .phsync = '-', .pvsync = '-', code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 40: .phsync = '-', .pvsync = '-', please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 41: .x_mm = 142, .y_mm = 228, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 41: .x_mm = 142, .y_mm = 228, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 42: }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 42: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33184/1/src/mainboard/google/kukui/panel_bit... PS1, Line 101: gpio_output(GPIO(SIM2_SIO), 1); trailing whitespace