Attention is currently required from: Kacper Stojek, Lean Sheng Tan, Werner Zeh.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72404 )
Change subject: soc/intel/elkhartlake/romstage/fsp_params.c: separate debug params
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/elkhartlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/72404/comment/30a4cdda_6673bf4d
PS2, Line 159: if (CONFIG_TTYS0_BASE == 0x3f8)
: m_cfg->PcdIsaSerialUartBase = ISA_SERIAL_BASE_ADDR_3F8;
: else if (CONFIG_TTYS0_BASE == 0x2f8)
: m_cfg->PcdIsaSerialUartBase = ISA_SERIAL_BASE_ADDR_2F8;
Yes I know, but since the other 2 configs are exposed they should be handled as well. […]
So how do you suggest to handle them?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72404
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84f7c19a7c2fd5a4db18f5a37e1c667da017aace
Gerrit-Change-Number: 72404
Gerrit-PatchSet: 2
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 11:16:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment