[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/herobrine: Only retrieve sku_id from EC once

[Shelley Chen (Code Review)]

Attention is currently required from: Shelley Chen.

Hello build bot (Jenkins), Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/70162

to look at the new patch set (#3).

Change subject: mb/google/herobrine: Only retrieve sku_id from EC once
......................................................................

mb/google/herobrine: Only retrieve sku_id from EC once

Currently, we are getting the sku id from the EC every time we call
the sku_id() function.  However, this will never change so we only
need to retrieve it once.  Inserting exit condition if sku id is
already set, then don't get it from the EC again.

Also, removing the ram_code function, which does nothing right now.
There is already a weak stub_function for this in
src/lib/coreboot_table.c that already does the same thing.

BUG=b:260740438,b:182963902
BRANCH=None
TEST=make sure image still boots to login on herobrine device

Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a
Signed-off-by: Shelley Chen 
---
M src/mainboard/google/herobrine/boardid.c
1 file changed, 35 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/70162/3