Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49909 )
Change subject: arch/x86/car.ld: Fix up blob reserved regions ......................................................................
arch/x86/car.ld: Fix up blob reserved regions
Drop duplicated assignment that rewound `.` back, and broke platforms using MRC.bin and DCACHE_RAM_MRC_VAR_SIZE.
Tested on out-of-tree Acer E5-573 (Broadwell), fixes booting. Also tested on Asrock B85M Pro4 (Haswell), also fixes booting.
Change-Id: I3f0153f776c07acf7cf92808b677b118c60507c3 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49909 Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/car.ld 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Nico Huber: Looks good to me, approved Matt DeVillier: Looks good to me, approved Arthur Heymans: Looks good to me, approved Patrick Rudolph: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 68144c9..5207157 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -94,8 +94,6 @@ .car.mrc_var . (NOLOAD) : { . += CONFIG_DCACHE_RAM_MRC_VAR_SIZE; } - -. = _car_region_end; .car.fspt_reserved . (NOLOAD) : { . += CONFIG_FSP_T_RESERVED_SIZE; }