Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )
Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... PS13, Line 524: : if (index != 0) : printk(BIOS_DEBUG, "CSE FWSTS%d: 0x%08x\n", index, reg); : else : printk(BIOS_DEBUG, "CSE [0x%x]=0x%08x\n", offset, reg); why we need to print this everytime, leave it to caller ?
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... PS13, Line 535: PCH_DEV_CSE add DEV NULL check ?
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... PS13, Line 537: if (!CONFIG(CONSOLE_SERIAL)) why we this guard?
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35225/13/src/soc/intel/common/block... PS13, Line 57: * no need for multi line comments