Hello build bot (Jenkins), Nico Huber, Angel Pons, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48862
to look at the new patch set (#2).
Change subject: drivers/intel/gma: Add stub for GFX0 device, include by default ......................................................................
drivers/intel/gma: Add stub for GFX0 device, include by default
Add a stub GFX0 device which includes only the PCI address, and include it by default for all platforms selecting INTEL_GMA_ACPI. Rework brightness level includes to utilize this new stub, and remove any duplicate device definitions in platform-level asl files.
Some OSes (eg, Windows, MacOS) require/prefer the ACPI device for the IGD to exist, even if ACPI brightness controls are not utilized. This change adds a GFX0 ACPI device for all boards whose platforms select INTEL_GMA_ACPI without requiring non-functional brightness controls to be added at the board level.
A subsequent change will eliminate the stub currently defined for platforms using the soc/intel/common implementation and migrate them to using this one.
Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/intel/gma/acpi/gma.asl A src/drivers/intel/gma/acpi/gma_stub.asl M src/northbridge/intel/gm45/acpi/gm45.asl M src/northbridge/intel/haswell/acpi/hostbridge.asl M src/northbridge/intel/i945/acpi/i945.asl M src/northbridge/intel/i945/acpi/igd.asl M src/northbridge/intel/ironlake/acpi/ironlake.asl M src/northbridge/intel/pineview/acpi/pineview.asl M src/northbridge/intel/sandybridge/acpi/sandybridge.asl M src/northbridge/intel/x4x/acpi/x4x.asl M src/soc/intel/baytrail/acpi/southcluster.asl M src/soc/intel/braswell/acpi/southcluster.asl M src/soc/intel/broadwell/acpi/hostbridge.asl 13 files changed, 36 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/48862/2