Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73270 )
Change subject: mb/google/rex: Remove `fixme` from gpio.h ......................................................................
mb/google/rex: Remove `fixme` from gpio.h
Remove `fixme` from gpio.h since it has been addressed.
BUG=none TEST=Only a cosmetic change
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: I79a2493dba6becd4b8c1ebf37e452a5a173eb396 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73270 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Tarun Tuli taruntuli@google.com --- M src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/gpio.h 1 file changed, 19 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Tarun Tuli: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/gpio.h b/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/gpio.h index 613a1fa..35e055b 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/gpio.h +++ b/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/gpio.h @@ -6,7 +6,6 @@ #include <soc/gpe.h> #include <soc/gpio.h>
-/* Fixme: Update proper GPIO number based on schematics */ /* WP signal to PCH */ #define GPIO_PCH_WP GPP_H10 /* GPIO IRQ for tight timestamps / wake support */