Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74110 )
Change subject: mb/google/myst: Add eSPI configuration ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74110/comment/74f93a2a_6c42e199 PS6, Line 7: .generic_io_range[0] = { : .base = 0x62, : .size = 1, : }, : .generic_io_range[1] = { : .base = 0x66, : .size = 1, : }, Why doesn't this comment apply to myst also?
``` /* * Only 0x62 and 0x66 are required. But, this is not supported by * standard IO decodes and there are only 4 generic I/O windows * available. Hence, open a window from 0x62-0x67. */ ```
https://review.coreboot.org/c/coreboot/+/74110/comment/fb5cdd78_3483e209 PS6, Line 29: .op_freq_mhz = ESPI_OP_FREQ_33_MHZ, For initial stability, should we start at 16MHz for bring up and then move up to 33?
https://review.coreboot.org/c/coreboot/+/74110/comment/51d00fbf_60b40e5d PS6, Line 31: ESPI_ALERT_PIN_IN_BAND go/myst-gpios lists this as `ESPI_EC_ALERT_SOC_ODL`, implying this should likely be `ESPI_ALERT_PIN_OPEN_DRAIN`.
https://review.coreboot.org/c/coreboot/+/74110/comment/83bc3d2a_a23fb847 PS6, Line 37: ESPI_VW_IRQ_LEVEL_HIGH(12) IRQ12 was removed from skyrim (https://review.coreboot.org/c/coreboot/+/63704). Why is it necessary again for myst?