build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: kodama: add a new configuration for Kodama. ......................................................................
Patch Set 1:
(35 comments)
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 53: .panel_bits_per_color = 8, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 53: .panel_bits_per_color = 8, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 54: .panel_bits_per_pixel = 24, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 54: .panel_bits_per_pixel = 24, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 55: .mode = { code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 55: .mode = { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 56: .name = "1200x1920@60Hz", code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 56: .name = "1200x1920@60Hz", please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 57: .pixel_clock = 159391, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 57: .pixel_clock = 159391, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 58: .lvds_dual_channel = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 58: .lvds_dual_channel = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 59: .refresh = 60, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 59: .refresh = 60, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 60: .ha = 1200, .hbl = 141, .hso = 80, .hspw = 1, .hborder = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 60: .ha = 1200, .hbl = 141, .hso = 80, .hspw = 1, .hborder = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 61: .va = 1920, .vbl = 61, .vso = 35, .vspw = 1, .vborder = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 61: .va = 1920, .vbl = 61, .vso = 35, .vspw = 1, .vborder = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 62: .phsync = '-', .pvsync = '-', code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 62: .phsync = '-', .pvsync = '-', please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 63: .x_mm = 142, .y_mm = 228, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 63: .x_mm = 142, .y_mm = 228, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 64: }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 64: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 69: {INIT_DCS_CMD, 1, {0x11} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 69: {INIT_DCS_CMD, 1, {0x11} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 70: {DELAY_CMD, 800, {} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 70: {DELAY_CMD, 800, {} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 71: {INIT_DCS_CMD, 2, {0x36, 0x03} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 71: {INIT_DCS_CMD, 2, {0x36, 0x03} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 72: {INIT_DCS_CMD, 1, {0x29} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 72: {INIT_DCS_CMD, 1, {0x29} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 73: {DELAY_CMD, 20, {} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 73: {DELAY_CMD, 20, {} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/1/src/mainboard/google/kukui/panel_kod... PS1, Line 98: else { else is not generally useful after a break or return