Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Default to undefined fw_config value ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47956/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47956/3//COMMIT_MSG@9 PS3, Line 9: In order to support the use case of leaving runtime probing of : multi-sourced peripherals to the payload (or beyond) before a device is : provisioned hmm... i'm not sure i followed that.
are you basically trying to distinguish between the case where fw_config hasn't been set and assumed to be 0 vs. explicitly set to 0? we get away with that because in most? cases the sub-fields are defined so that a value of 0 means no device.
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c File src/lib/fw_config.c:
PS3: please update Documentation/lib/fw_config.md to match.
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@17 PS3, Line 17: ; can we simply start with fw_config_value = UNDEFINED_FW_CONFIG ?
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@75 PS3, Line 75: bool fw_config_probe(const struct fw_config *match) is there ever a case where we would still want to use this version?
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@132 PS3, Line 132: fw_config_probe fw_config_probe_nodefault