Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33919 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: set a board type to AMD_PLATFORM_DESKTOP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33919/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33919/1//COMMIT_MSG@9
PS1, Line 9: incorrect
This option seems to have some effect in the AGESA code on PCIe configuration (look for GfxCardWorkaround). Can you state why you think this change is needed, since it's not a cosmetic change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02adedffe8624c38e7b93fadd0449ddf094388fd
Gerrit-Change-Number: 33919
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 30 Jun 2019 19:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment