Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33267 )
Change subject: nb/amd/amdmct/mct_ddr3: Remove duplicate code ......................................................................
nb/amd/amdmct/mct_ddr3: Remove duplicate code
This conditional is exactly the same as the one right below it, except the operations are reorganized slightly.
Change-Id: I00c19a467d23a0736bc2a33b516f97080039e634 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1347321 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33267 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 5be4566..945ae82 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3090,12 +3090,6 @@ if (pDCTstat->DIMMValidDCT[0] && pDCTstat->DIMMValidDCT[1] && mctGet_NVbits(NV_Unganged)) interleave_channels = 1;
- dword = (Get_NB32_DCT(dev, dct, 0x240) >> 4) & 0xf; - if (dword > 6) - read_odt_delay = dword - 6; - else - read_odt_delay = 0; - dword = Get_NB32_DCT(dev, dct, 0x240); delay = (dword >> 4) & 0xf; if (delay > 6)