Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 118: static int transfer_buffer_valid(struct transfer_info_struct *ptr) const struct transfer_info_struct *ptr
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 129: #if CONFIG(VBOOT) Why did this #if condition come back?
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 130: struct transfer_info_struct *info = (struct transfer_info_struct *) const
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 133: if (transfer_buffer_valid(info)) { fwiw, you can save horizontal real estate by bailing early:
if (!transfer_buffer_valid(info) || info->timestamp == 0) return;
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 158: tse->entry_stamp += psp_ts_table->base_time + base_timestamp; I think you should probably leave a note that base_timestamp is added here because timestamp_add() subtracts that value when adding new entries.