Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42130 )
Change subject: superio/nuvoton: Inline `nuvoton_hwm_select_bank`
......................................................................
Patch Set 16:
have you checked if no other board with a winbond SIO uses the HWM? if so, please comment on that and i'll +2 the patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I103a4ea4cef24844d382854c9358bbb37d229e04
Gerrit-Change-Number: 42130
Gerrit-PatchSet: 16
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:07:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment