Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45832 )
Change subject: tgl/usb: disable TBT if hardware is not USB4
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45832/5/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45832/5/src/soc/intel/tigerlake/fsp...
PS5, Line 314: mainboard_supports_usb4())
since mainboard_silicon_init_params() runs at the end of this function it could just disable these UPDs directly without needing another mainboard callback.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07d5c416c79c40e9f85d721930549cf3374d327c
Gerrit-Change-Number: 45832
Gerrit-PatchSet: 5
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 17:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment