Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39579 )
Change subject: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39579/3/src/soc/intel/apollolake/in...
File src/soc/intel/apollolake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/39579/3/src/soc/intel/apollolake/in...
PS3, Line 49: #define SA_DEV_SLOT_GMM 0x08
In GLK, GNA device ID is 0x03.
Please refer to Document#: 569262(Glk EDS Vol-1 rev2-7). Same comment applies for the change in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72b1dd78705894f0462c7fbe89b76551950c2392
Gerrit-Change-Number: 39579
Gerrit-PatchSet: 3
Gerrit-Owner: Franklin (Yanjin) He
franklinh@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Franklin (Yanjin) He
franklinh@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Mar 2020 01:53:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment