Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mb/google/hatch: Create Akemi variant
......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch...
PS22, Line 125: /* F3 : MEM_STRAP_3 */
: PAD_CFG_GPI(GPP_F3, NONE, PLTRST),
: /* F10 : MEM_STRAP_2 */
: PAD_CFG_GPI(GPP_F10, NONE, PLTRST),
The MEM_STRAP_* pins are not required to be in the early_gpio_table. […]
Done
https://review.coreboot.org/c/coreboot/+/33824/22/src/mainboard/google/hatch...
PS22, Line 153: /* H19 : MEM_STRAP_0 */
: PAD_CFG_GPI(GPP_H19, NONE, PLTRST),
: /* H22 : MEM_STRAP_1 */
: PAD_CFG_GPI(GPP_H22, NONE, PLTRST),
See above, these are not required
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a868839e2c598f8052d37c99713bc58b21e887c
Gerrit-Change-Number: 33824
Gerrit-PatchSet: 23
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 23:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment