Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: lib/libpayload: Replace strapping_ids with new board configuration entry
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46605/12/payloads/libpayload/includ...
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/46605/12/payloads/libpayload/includ...
PS12, Line 83: CB_TAG_BOARD_CONFIG = 0x0040,
0x39 + 1 = 0x3a […]
There were some merge conflicts (other things added), so I just bumped the tag up some. In retrospect, probably should have just added 1 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ecec847ee77b72233587c1ad7f124e2027470bf
Gerrit-Change-Number: 46605
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 16:15:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment