Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31026 )
Change subject: AGESA/binaryPI: Add NULL pointers check
......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
I spent a little time looking at build//static.c for apu2 vs. a stoneyridge board. It's not immediately clear to me why apu2 isn't working but grunt is OK.
These apu2 variant boards are headless, integrated graphices 0:1.0 and 0:1.1 are disabled devices (which may not even exist in the silicon at all).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31026
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I785350c171a642207c5fab884a953d45a3bfe592
Gerrit-Change-Number: 31026
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 21 Jan 2019 19:15:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment