Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37995 )
Change subject: mainboard/asus/p10s-series: Initial port to ASUS P10S-I ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 33: // CPU
I would drop this comment
Done
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 35: : Scope (_SB) { : Device (PCI0)
Device (_SB. […]
Done
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 44: // Chipset specific sleep states
I just dropped these with CB:37855
Done
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... File src/mainboard/asus/p10s-series/include/mainboard.h:
https://review.coreboot.org/c/coreboot/+/37995/3/src/mainboard/asus/p10s-ser... PS3, Line 21: #endif /* _OARD_ASUS_P10S_SERIES_H */
OARD?
Done