[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/common: Add InSMM.STS support

[Michael Niewöhner (Code Review)]

Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51796 )

Change subject: [WIP] soc/intel/common: Add InSMM.STS support
......................................................................

Patch Set 6:

(2 comments)

File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/51796/comment/24c69dfc_1b3cc041 
PS6, Line 276: 0x1fe
we really should add a name for that (include/cpu/intel/msr.h)

https://review.coreboot.org/c/coreboot/+/51796/comment/9d75d4b3_00901e1e 
PS6, Line 267: 	msr_t msr = {
             : 		.lo = read32((void *)(uintptr_t)0xfed30880),
             : 		.hi = 0,
             : 	};
             : 	if (enable_writes)
             : 		msr.lo |= 1;
             : 	else
             : 		msr.lo &= ~1;
             : 
             : 	wrmsr(0x1fe, msr);
             : 
what about this? 😊

uint32_t reg = read32((void *)(uintptr_t)0xfed30880);
msr_unset_and_set(0x1fe, ~0, reg | enable_writes);