Attention is currently required from: Martin Roth, zanxi chen, Henry Sun, Weimin Wu, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51017 )
Change subject: mb/google/dedede/var/storo: Add LTE module support into devicetree and associated GPIO configuartion ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51017/comment/645fe29e_36b4963d PS2, Line 2: chenzanxi Please use *Zanxi Chen*.
https://review.coreboot.org/c/coreboot/+/51017/comment/fc1a4459_23f9ace2 PS2, Line 8: associated GPIO configuartion Please only use one line, and make it shorter.
Support LTE module
https://review.coreboot.org/c/coreboot/+/51017/comment/7fa6aa8c_46fdb1df PS2, Line 14: TEST=LTE function is OK How did you check it exactly?
https://review.coreboot.org/c/coreboot/+/51017/comment/370a6c45_e15988e0 PS2, Line 17: chenzanxi Ditto.
File src/mainboard/google/dedede/variants/storo/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51017/comment/02da908e_dfc7bd6a PS2, Line 5: smm-y += variant.c Why is SMM needed?
File src/mainboard/google/dedede/variants/storo/variant.c:
https://review.coreboot.org/c/coreboot/+/51017/comment/dd1bd97f_55c557b6 PS2, Line 11: mdelay(20); Where is the 20 ms delay documented?