Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Jérémy Compostella, Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86361?usp=email )
Change subject: soc/intel/common: Add low battery shutdown function
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/reset.c:
https://review.coreboot.org/c/coreboot/+/86361/comment/fc56a014_74d91e37?usp... :
PS4, Line 27: poweroff();
Wait, where did the rest of this function go? Who is doing the delay and the elog entry now? (If this function does nothing more than `poweroff()`, it doesn't need to exist, the caller could just call `poweroff()` directly.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86361?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4
Gerrit-Change-Number: 86361
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 00:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No