Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33421 )
Change subject: util/superiotool/nuvoton.c: add NCT5539D register dump
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/33421/10/util/superiotool/nuvoton.c
File util/superiotool/nuvoton.c:
https://review.coreboot.org/#/c/33421/10/util/superiotool/nuvoton.c@611
PS10, Line 611: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,
: 0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,EOT}}
see my comments on the last revision of this part
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55068035ca574b22d0fea81e1a291f7cf0329d3
Gerrit-Change-Number: 33421
Gerrit-PatchSet: 10
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 13 Jun 2019 00:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment