Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34929 )
Change subject: arch/x86: Fix spinlocks for cases of __PRE_RAM__ ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34929/3/src/arch/x86/include/arch/s... File src/arch/x86/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/34929/3/src/arch/x86/include/arch/s... PS3, Line 39: ENV_STAGE_HAS_DATA_SECTION
Even if a stage has a data section (say we add that ability to CAR stages: bootblock, verstage, roms […]
I agree. I know AGESA fam14 has cache coherency issues. Based on some of the feedback, fam10-15 might as well, even though these extra romstage spinlocks were infact implemented for those platforms.