Attention is currently required from: Zheng Bao. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/58559
to review the following change.
Change subject: amdfwtool: Move the field filling into function ......................................................................
amdfwtool: Move the field filling into function
Change-Id: I732bb358d397d3d4758b669bd90ce1d31fc27a9b Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/58559/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index d6811c8..625f27f 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -410,6 +410,7 @@ case BHD2_COOKIE: /* caller is responsible for lookup mode */ cdir->header.cookie = cookie; + cdir->header.lookup = 1; cdir->header.num_entries = count; cdir->header.reserved[0] = 0; cdir->header.reserved[1] = 0; @@ -1699,7 +1700,6 @@ psp_combo_dir->entries[combo_index].id = get_psp_id(cb_config.soc_id); psp_combo_dir->entries[combo_index].lvl2_addr = BUFF_TO_RUN(ctx, pspdir);
- psp_combo_dir->header.lookup = 1; fill_dir_header(psp_combo_dir, combo_index + 1, PSP2_COOKIE, &ctx); } #endif @@ -1748,7 +1748,6 @@ bhd_combo_dir->entries[combo_index].id = get_psp_id(cb_config.soc_id); bhd_combo_dir->entries[combo_index].lvl2_addr = BUFF_TO_RUN(ctx, biosdir);
- bhd_combo_dir->header.lookup = 1; fill_dir_header(bhd_combo_dir, combo_index + 1, BHD2_COOKIE, &ctx); } #endif