Hello Aaron Durbin, Angel Pons, Arthur Heymans, Patrick Rudolph, Marshall Dawson, Matt DeVillier, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37398
to look at the new patch set (#3).
Change subject: monotonic_timer: Avoid calls from APs ......................................................................
monotonic_timer: Avoid calls from APs
Fixes regression with commit 45ddb4344
console,boot_state: Exclude printk() from reported times
This was witnessed to cause boot regressions together with LAPIC_MONOTONIC_TIMER=y. The code in cpu/x86/lapic/apic_timer.c for timer_monotonic_get() is not SMP safe as LAPIC timers do not run as synchronised as TSCs.
TBD: Time spent in printk() for APs is now incorrect in logs.
Change-Id: I1ea2c1e7172f8ab3692b42dee3f669c5942d864a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/console/printk.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/37398/3