Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38832 )
Change subject: Documentation/ifdtool: modify IFD regions ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... File Documentation/ifdtool/layout.md:
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 37: It is possible to adjust the IFD regions on a firmware image or on a Flash Descriptor file directly.
limit line length to 72chars
Done
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 45: Reduce
Reducing
Done
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 47: ##### Step 1 - Dump IFD regions into a flashrom layout file
needs more details. What is descriptor. […]
Done
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 48: $ ifdtool -f ifd_old.layout descriptor.bin
encapsulate with […]
Done
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 57: ##### Step 2 - Modify the layout file
This should go more into detail. […]
Done
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 117:
by mistake. Will be undone next patchset.
Done