Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add Family 15h ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 6: "Clustered MultiThreading"
This bugged me before and I didn't say anything. […]
Copy/paste from Wikipedia.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 7: replacing SMT
remove
Done
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 8: models
This is uncomfortably short now. How about […]
Done
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 15: module
Regardless of above, this is certainly called a compute unit and not a module.
Again Wikipedia. Will change.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 20: .
Could also note that Family 15h comprises 3-chip solutions, 2, and single-chip. […]
Ack
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 28: :
could delete this
Don't think so.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 29:
Probably want to remove the space
Ack