Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Fred Reitberger, Felix Held.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74191 )
Change subject: mb/amd/mayan: Update the DXIO descriptors for mayan ......................................................................
Patch Set 4:
(7 comments)
Patchset:
PS4: Addressed Fred's review comments.
File src/mainboard/amd/mayan/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74191/comment/44410ebe_a6a993a3 PS3, Line 11: const
Any specific reason the 'const' was dropped? Does not look like it is modified elsewhere.
It was dropped to dynamically update the .port_present field in the descriptor structure. I have added it back as I have seen you have suggested a way to keep the 'const' in the other review thread. I will take a look at that.
https://review.coreboot.org/c/coreboot/+/74191/comment/b05e1080_5dcf77d2 PS3, Line 42: .link_aspm = 2,
Prefer using the enums in vc/amd/fsp/phoenix/platform_descriptors.h - `ASPM_L1` here […]
Done
https://review.coreboot.org/c/coreboot/+/74191/comment/a882ddcc_8693b7e3 PS3, Line 43: .link_aspm_L1_1 = 1, : .link_aspm_L1_2 = 1,
Prefer using `true` here over `1`
Done
https://review.coreboot.org/c/coreboot/+/74191/comment/70bb3fb0_2a19a69f PS3, Line 47: .clk_pm_support = 1,
Does the FSP support this?
Yes, it does.
https://review.coreboot.org/c/coreboot/+/74191/comment/57567dbd_c62a5a38 PS3, Line 66: //.gpio_group_id = 30,
Is this just a placeholder for now? If so, please add "TODO". […]
Done, Removed.
https://review.coreboot.org/c/coreboot/+/74191/comment/390019c4_1e479e45 PS3, Line 90: },
GBE? SD card? WLAN?
Will add those in a separate review.