HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: cast all void *cbmem_top_chipset() function to uintptr_t ......................................................................
Patch Set 1:
(3 comments)
it needs manual rebase you also need to touch "src/include/cbmem.h" file.
will you also change returned value of cbmem_top(void) to uinptr_t in a separate patch ?
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@7 PS1, Line 7: cast all void *cbmem_top_chipset() function to uintptr_t src: cast all void *cbmem_top_chipset() function to uintptr_t
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@12 PS1, Line 12: root ? :)
https://review.coreboot.org/c/coreboot/+/43756/1/src/arch/x86/cbmem.c File src/arch/x86/cbmem.c:
https://review.coreboot.org/c/coreboot/+/43756/1/src/arch/x86/cbmem.c@1 PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ : : #include <cbmem.h> : #include <stdint.h> : : #if CONFIG(CBMEM_TOP_BACKUP) : : uintptr_t cbmem_top_chipset(void) : { : /* Top of CBMEM is at highest usable DRAM address below 4GiB. */ : return (uintptr_t)(restore_top_of_low_cacheable()); : } : : #endif /* CBMEM_TOP_BACKUP */ this file is removed see https://review.coreboot.org/c/coreboot/+/43326