Attention is currently required from: Sergii Dmytruk, Timothy Pearson, Ron Minnich.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57076 )
Change subject: ppc64/bootblock_crt0.S: minimal implementation for bootblock C environment
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
Patchset:
PS10:
with coding style weirdness resolved: LGTM
File src/arch/ppc64/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/57076/comment/b7c99c7e_6d39aab3
PS10, Line 64:
are you working with 4spaces wide tabs or how comes that there are two tabs here (and in other cases where the opcode has 2 or 3 letters)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I878ef61619eb4a191805c8911d001312a0d717a0
Gerrit-Change-Number: 57076
Gerrit-PatchSet: 10
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 24 Nov 2021 14:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment