Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32071 )
Change subject: sb/intel/sandybridge/early_pch: Make DMI init more readable
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32071/5/src/southbridge/intel/bd82x6x/pch.h
File src/southbridge/intel/bd82x6x/pch.h:
https://review.coreboot.org/#/c/32071/5/src/southbridge/intel/bd82x6x/pch.h@...
PS5, Line 313: #define VCNEGPND 2
Please align the 2 with two tabs as below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I404515b77a22324f55581f117d79630be4ba64dd
Gerrit-Change-Number: 32071
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Apr 2019 11:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment