Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys
......................................................................
Patch Set 15:
(3 comments)
The motivation for this change is unclear to me.
https://review.coreboot.org/c/coreboot/+/36654/13//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36654/13//COMMIT_MSG@9
PS13, Line 9: , we will
These are two sentences: … 0xE0. We will …
https://review.coreboot.org/c/coreboot/+/36654/13//COMMIT_MSG@10
PS13, Line 10: these except for the power button, F12 and cursor keys on drallion.
Why should these be ignored? What effect do these presses currently have to be ignored?
https://review.coreboot.org/c/coreboot/+/36654/13//COMMIT_MSG@13
PS13, Line 13: require
requires
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c11939d18391bebe53ca21cf33a096ba369cd56
Gerrit-Change-Number: 36654
Gerrit-PatchSet: 15
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 Nov 2019 13:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment