Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )
Change subject: soc/intel/cannonlake: Support different SPD read type for each slot ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/cnl_memcfg_... File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/cnl_memcfg_... PS6, Line 144: No valid way to read mem info. Just put this in die?
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... PS6, Line 130: * to indicate that the channel is populated. For example,
Are you saying we can just remove channel_empty[] here? Furquan/Tim/Paul, if so, do we still need a strapping GPIO pin for single/dual channel memory skus?
What Patrick meant is that spd_info is being filled for each slot which means that it already provides information about which channel is populated and which is not. However, in order to fill spd_info, you would still need the strapping GPIO on hatch.