Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36682 )
Change subject: soc/intel/car: Add support for bootguard CAR
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36682/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/36682/6/src/soc/intel/common/block/...
PS6, Line 214: clear_car
on Purley bit0 in MSR 0x139 is set when B_BOOT_GUARD_SACM_INFO_CAPABILITY is set in BOOTGUARD_MSR. […]
Just remembered another thing that needs to be done: Stop the PBE timer before trying to do MP init. Otherwise, sending SIPIs to wake up the APs causes a system reset. To stop that timer, write one to MSR 0x139 bit 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifac5267f8f4b820a61519fb4a497e2ce7075cc40
Gerrit-Change-Number: 36682
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sachin Agrawal
sachin.agrawal@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Tue, 24 Dec 2019 15:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment