Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33252 )
Change subject: security/tpm/tss/tcg-2.0: Add multi digits support to tlcl_extend()
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2....
File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2....
PS4, Line 288: /*
: * This is a union, but as of now we support just one digest - sha256, so
: * there is just one element.
: */
The comment need to be updated.
https://review.coreboot.org/c/coreboot/+/33252/4/src/security/tpm/tss/tcg-2....
PS4, Line 294: invalidate_pcrs;
That's not part of spec right? Do we really need that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d86c41c23e4e93a84e0527d7cddcfd30d5d8394
Gerrit-Change-Number: 33252
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-Comment-Date: Wed, 17 Jul 2019 11:31:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment