Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38290 )
Change subject: xcompile: Use GCC wrappers for ar, nm
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38290/3/util/xcompile/xcompile
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/38290/3/util/xcompile/xcompile@296
PS3, Line 296: NM_${TARCH}:=${GCCPREFIX}gcc-nm
Come to think of it, should these be guarded with something to only use these wrappers if GCC is use […]
Our support for non-gcc compilers is _really_ limited so I wouldn't care too much about it right now. clang probably needs its own special variants of these tools.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdae4faabf67bf6a4bb8c38970f6189646ee74b3
Gerrit-Change-Number: 38290
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 16:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment